Reviewers: Weiliang,
Message:
PTAL.
Description:
X87: [strong] Check arity of functions
port 3226e980200035f37c86fef4b11fb307e17764a2 (28346).
original commit message:
[strong] Check arity of functions
In strong mode it is an error to call a function with too few
arguments.
This is enforced inside the ArgumentsAdaptorTrampoline.
This does not yet handle rest parameter
BUG=
Please review this at https://codereview.chromium.org/1139913007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+15, -0 lines):
M src/x87/builtins-x87.cc
Index: src/x87/builtins-x87.cc
diff --git a/src/x87/builtins-x87.cc b/src/x87/builtins-x87.cc
index
28ead0c6544bbb9b73f3660702d6158128ed8890..f45f1f0599b957e779108acf3f7e9db7500d7652
100644
--- a/src/x87/builtins-x87.cc
+++ b/src/x87/builtins-x87.cc
@@ -1577,6 +1577,21 @@ void
Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) {
{ // Too few parameters: Actual < expected.
__ bind(&too_few);
+
+ // If the function is strong we need to throw an error.
+ Label weak_function;
+ __ mov(ecx, FieldOperand(edi, JSFunction::kSharedFunctionInfoOffset));
+ __ test_b(FieldOperand(ecx, SharedFunctionInfo::kStrongModeByteOffset),
+ 1 << SharedFunctionInfo::kStrongModeBitWithinByte);
+ __ j(equal, &weak_function, Label::kNear);
+
+ {
+ FrameScope frame(masm, StackFrame::MANUAL);
+ EnterArgumentsAdaptorFrame(masm);
+ __ CallRuntime(Runtime::kThrowStrongModeTooFewArguments, 0);
+ }
+
+ __ bind(&weak_function);
EnterArgumentsAdaptorFrame(masm);
// Copy receiver and all actual arguments.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
