Wow, this email reached my inbox 5 mins ago. Sorry for not responding before.
yours, anton. On Tue, Dec 22, 2009 at 9:53 PM, <[email protected]> wrote: > Reviewers: antonm, > > Message: > The mac x64 debug build is failing with: > > g++ -o obj/debug/x64/fast-codegen-x64.o -c -Wall -Werror -W > -Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m64 -g -O0 -ansi > -mmacosx-version-min=10.4 -fno-rtti -fno-exceptions -Wall -Werror -W > -Wno-unused-parameter -Wnon-virtual-dtor -pedantic -m64 -g -O0 -ansi > -mmacosx-version-min=10.4 -DV8_TARGET_ARCH_X64 -DENABLE_DISASSEMBLER -DDEBUG > -DENABLE_DEBUGGER_SUPPORT -DV8_NATIVE_REGEXP -DV8_ENABLE_CHECKS > -DENABLE_LOGGING_AND_PROFILING -I/Users/ryah/node/deps/v8/src > /Users/ryah/node/deps/v8/src/x64/fast-codegen-x64.cc > /Users/ryah/node/deps/v8/src/x64/fast-codegen-x64.cc: In member function > 'void > v8::internal::FastCodeGenerator::StoreToFrameField(int, > v8::internal::Register)': > /Users/ryah/node/deps/v8/src/x64/fast-codegen-x64.cc:1681: error: call of > overloaded 'CheckEqualsHelper(const char [53], int, const char [68], long > int, > const char [36], intptr_t)' is ambiguous > /Users/ryah/node/deps/v8/src/checks.h:75: note: candidates are: void > CheckEqualsHelper(const char*, int, const char*, int, const char*, int) > /Users/ryah/node/deps/v8/src/checks.h:89: note: void > CheckEqualsHelper(const char*, int, const char*, int64_t, const char*, > int64_t) > /Users/ryah/node/deps/v8/src/checks.h:187: note: void > CheckEqualsHelper(const char*, int, const char*, double, const char*, > double) > scons: *** [obj/debug/x64/fast-codegen-x64.o] Error 1 > scons: building terminated because of errors. > > > This change fixes it. > > Description: > Fix mac x64 build. > > This is similar to the issue resolved in r3086 > http://codereview.chromium.org/284012 > > Please review this at http://codereview.chromium.org/509029 > > Affected files: > M src/x64/fast-codegen-x64.cc > > > Index: src/x64/fast-codegen-x64.cc > diff --git a/src/x64/fast-codegen-x64.cc b/src/x64/fast-codegen-x64.cc > index > ba22135725a7032099ec7af232fdf841c00719ce..6c96ad60afc5659adfce64a563cafb7aa3d611d6 > 100644 > --- a/src/x64/fast-codegen-x64.cc > +++ b/src/x64/fast-codegen-x64.cc > @@ -1678,8 +1678,7 @@ Register FastCodeGenerator::context_register() { > return rsi; } > > > void FastCodeGenerator::StoreToFrameField(int frame_offset, Register value) > { > - ASSERT_EQ(POINTER_SIZE_ALIGN(frame_offset), > - static_cast<intptr_t>(frame_offset)); > + ASSERT_EQ(POINTER_SIZE_ALIGN(frame_offset), > static_cast<int>(frame_offset)); > __ movq(Operand(rbp, frame_offset), value); > } > > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
