Reviewers: jarin,
Description:
[turbofan] Reenable feedback for LoadNamed.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/1140943003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/compiler/js-type-feedback.cc
M src/flag-definitions.h
Index: src/compiler/js-type-feedback.cc
diff --git a/src/compiler/js-type-feedback.cc
b/src/compiler/js-type-feedback.cc
index
04861ea53227fbe0328254c22adc70edaef6335d..7cccfa721a0497f92c36b0164de22891bef1d49b
100644
--- a/src/compiler/js-type-feedback.cc
+++ b/src/compiler/js-type-feedback.cc
@@ -276,6 +276,7 @@ Reduction
JSTypeFeedbackSpecializer::ReduceJSLoadProperty(Node* node) {
Reduction JSTypeFeedbackSpecializer::ReduceJSStoreNamed(Node* node) {
DCHECK(node->opcode() == IrOpcode::kJSStoreNamed);
+ if (true) return NoChange(); // TODO(titzer): storenamed is broken
Node* frame_state_before = GetFrameStateBefore(node);
if (frame_state_before == nullptr) return NoChange();
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index
6d6312981989a677faed1c899b93436707840365..70d40b3b428866886d1e8b42318b4036e885bbdd
100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -385,8 +385,7 @@ DEFINE_BOOL(omit_map_checks_for_leaf_maps, true,
DEFINE_BOOL(turbo, false, "enable TurboFan compiler")
DEFINE_BOOL(turbo_greedy_regalloc, false, "use the greedy register
allocator")
DEFINE_IMPLICATION(turbo, turbo_deoptimization)
-// TODO(titzer): turn back on type feedback in turbo mode.
-// DEFINE_IMPLICATION(turbo, turbo_type_feedback)
+DEFINE_IMPLICATION(turbo, turbo_type_feedback)
DEFINE_STRING(turbo_filter, "~~", "optimization filter for TurboFan
compiler")
DEFINE_BOOL(trace_turbo, false, "trace generated TurboFan IR")
DEFINE_BOOL(trace_turbo_graph, false, "trace generated TurboFan graphs")
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
