This is ready for review. What is done in this CL is mostly refactoring. I
only
support C-style for loops in this CL.
Various forms of for-each made the CLe mashroom out of control, so I'll do
that
in subsequent CLs.
https://codereview.chromium.org/1128043006/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2425
src/parser.cc:2425: Expect(Token::ASSIGN, ok);
On 2015/05/13 16:29:29, arv wrote:
Maybe add a macro for CHECK_OK_VOID?
Considered this but decided against. Too many CHECK_OK macros...
https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode2470
src/parser.cc:2470: parsing_result->out = first_name;
On 2015/05/13 16:29:29, arv wrote:
rename out?
I did one better and removed it completely
https://codereview.chromium.org/1128043006/diff/1/src/parser.cc#newcode3468
src/parser.cc:3468: ParseVariableDeclarations(kForStatement,
&parsing_result, CHECK_OK);
On 2015/05/13 16:29:29, arv wrote:
Can this code be shared with the sloppy branch?
Maybe in the next CL; I shared some.
https://codereview.chromium.org/1128043006/diff/1/src/pattern-rewriter.cc
File src/pattern-rewriter.cc (right):
https://codereview.chromium.org/1128043006/diff/1/src/pattern-rewriter.cc#newcode27
src/pattern-rewriter.cc:27: VisitorState state;
On 2015/05/13 16:29:29, arv wrote:
or maybe:
VisitorState state(block, decl, names, ok);
State removed.
https://codereview.chromium.org/1128043006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
