http://codereview.chromium.org/515012/diff/1/4 File src/arm/virtual-frame-arm.cc (right):
http://codereview.chromium.org/515012/diff/1/4#newcode149 src/arm/virtual-frame-arm.cc:149: if (count < 5) { On 2009/12/23 14:30:52, Mads Ager wrote: > Please introduce a platform-dependent named constant for this value. Done. http://codereview.chromium.org/515012/diff/1/4#newcode155 src/arm/virtual-frame-arm.cc:155: // For more kocals a loop in generated code is more compact. On 2009/12/23 14:30:52, Mads Ager wrote: > kocals -> locals Done. http://codereview.chromium.org/515012/diff/1/2 File src/ia32/virtual-frame-ia32.cc (right): http://codereview.chromium.org/515012/diff/1/2#newcode543 src/ia32/virtual-frame-ia32.cc:543: for (int i = 0; i < count; i++) { On 2009/12/23 14:30:52, Mads Ager wrote: > This loop should be extracted. It happens in all branches, so you can just > always do it at the end. Done. http://codereview.chromium.org/515012/diff/1/3 File src/x64/virtual-frame-x64.cc (right): http://codereview.chromium.org/515012/diff/1/3#newcode155 src/x64/virtual-frame-x64.cc:155: for (int i = 0; i < count; i++) { On 2009/12/23 14:30:52, Mads Ager wrote: > Ditto. Done. http://codereview.chromium.org/515012 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
