Reviewers: vogelheim,
Description:
Remove unnecessary Isolate::Current calls from hydrogen-instructions
BUG=none
[email protected]
LOG=n
Please review this at https://codereview.chromium.org/1144523004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M src/hydrogen-instructions.h
M src/hydrogen-instructions.cc
Index: src/hydrogen-instructions.cc
diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc
index
974b65b715fb6ec86c0026d201a682d481ace8af..d9cccfcaec0b50db4e5aa67148b752a4c9c5e341
100644
--- a/src/hydrogen-instructions.cc
+++ b/src/hydrogen-instructions.cc
@@ -2976,7 +2976,7 @@ std::ostream& HConstant::PrintDataTo(std::ostream&
os) const { // NOLINT
os << reinterpret_cast<void*>(external_reference_value_.address())
<< " ";
} else {
// The handle() method is silently and lazily mutating the object.
- Handle<Object> h =
const_cast<HConstant*>(this)->handle(Isolate::Current());
+ Handle<Object> h = const_cast<HConstant*>(this)->handle(isolate);
os << Brief(*h) << " ";
if (HasStableMapValue()) os << "[stable-map] ";
if (HasObjectMap()) os << "[map " << *ObjectMap().handle() << "] ";
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h
index
ff02212dcb892945caa1a9c538d2da43f3bc3ae8..1288bc07edced5fdad3c802054c00de634581e91
100644
--- a/src/hydrogen-instructions.h
+++ b/src/hydrogen-instructions.h
@@ -6843,7 +6843,7 @@ class HStoreNamedField final : public
HTemplateInstruction<3> {
Handle<Map> transition_map() const {
if (has_transition()) {
return Handle<Map>::cast(
- HConstant::cast(transition())->handle(Isolate::Current()));
+ HConstant::cast(transition())->handle(isolate()));
} else {
return Handle<Map>();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
