https://codereview.chromium.org/1132163011/diff/20001/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1132163011/diff/20001/src/harmony-typedarray.js#newcode121
src/harmony-typedarray.js:121: var array = %_CallFunction(GlobalArray,
source, mapfn, thisArg, $arrayFrom);
Add todo. It would surely be better to not have a temporary array.
Can you do the $innerArrayFrom solution here too?
https://codereview.chromium.org/1132163011/diff/20001/test/mjsunit/harmony/typedarray-from.js
File test/mjsunit/harmony/typedarray-from.js (right):
https://codereview.chromium.org/1132163011/diff/20001/test/mjsunit/harmony/typedarray-from.js#newcode64
test/mjsunit/harmony/typedarray-from.js:64: var kSet = new Set([1, 2,
3]);
kSet -> set
https://codereview.chromium.org/1132163011/diff/20001/test/mjsunit/harmony/typedarray-from.js#newcode103
test/mjsunit/harmony/typedarray-from.js:103: called = true;
another way to do this is to use a counter and then assert that it is 1
afterwards.
https://codereview.chromium.org/1132163011/diff/20001/test/mjsunit/harmony/typedarray-from.js#newcode124
test/mjsunit/harmony/typedarray-from.js:124:
remove empty line
https://codereview.chromium.org/1132163011/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
