lgtm
https://codereview.chromium.org/1134333005/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1134333005/diff/1/src/bootstrapper.cc#newcode1015
src/bootstrapper.cc:1015: CacheInitialJSArrayMaps(native_context(),
initial_map, false);
On 2015/05/18 09:32:37, rossberg wrote:
On 2015/05/18 09:15:56, Dmitry Lomov (chromium) wrote:
> Where do you call this function with 'true'?
In JSFunction::SetInstancePrototype (objects.cc:10365), where it also
calls it
with false again. To be honest, I don't understand this -- why is the
initialisation of the (weak) array maps happening in two places?
Sounds like a bug/oversight - ask Yang or Ulan?
https://codereview.chromium.org/1134333005/diff/1/test/mjsunit/strong/literals.js
File test/mjsunit/strong/literals.js (right):
https://codereview.chromium.org/1134333005/diff/1/test/mjsunit/strong/literals.js#newcode20
test/mjsunit/strong/literals.js:20: assertTrue(%IsStrong({a: 0, b: 0}));
On 2015/05/18 09:32:37, rossberg wrote:
On 2015/05/18 09:15:56, Dmitry Lomov (chromium) wrote:
> On 2015/05/13 16:39:37, arv wrote:
> > Please add tests with accessors, methods, __proto__, super and
computed
> property
> > names.
>
> Also regexps, if I understand the patch correctly.
Those don't work yet, see the existing tests below. (Or did you mean
something
else?)
I see, missed that.
https://codereview.chromium.org/1134333005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
