https://codereview.chromium.org/1125193005/diff/60001/src/heap/gc-tracer.h
File src/heap/gc-tracer.h (right):
https://codereview.chromium.org/1125193005/diff/60001/src/heap/gc-tracer.h#newcode282
src/heap/gc-tracer.h:282: typedef RingBuffer<AllocationEvent,
kRingBufferMaxSize> AllocationEventBuffer;
On 2015/05/12 17:04:17, Hannes Payer wrote:
I am wondering about the size of the ring buffer. You get now finer
grained
samples. I think the buffer should be bigger for that to average out
spikes.
Adding a new allocation event for each idle notification made the result
more noisy. I reworked this part:
- Add allocation events to the buffer only after GC (as before).
- Separately accumulate (duration_ms, allocated_bytes) since the last GC
(see new_space_allocation_duration_since_gc_,
new_space_allocation_in_bytes_since_gc_ in gc-tracer.h)
https://codereview.chromium.org/1125193005/diff/60001/src/heap/gc-tracer.h#newcode488
src/heap/gc-tracer.h:488: double new_space_allocation_time_ms_;
On 2015/05/12 17:04:17, Hannes Payer wrote:
Please describe the added fields.
Done.
https://codereview.chromium.org/1125193005/diff/60001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1125193005/diff/60001/src/heap/heap.h#newcode2169
src/heap/heap.h:2169: size_t crankshaft_codegen_bytes_generated_;
On 2015/05/12 17:04:17, Hannes Payer wrote:
newline
Done.
https://codereview.chromium.org/1125193005/diff/60001/src/heap/spaces.h
File src/heap/spaces.h (right):
https://codereview.chromium.org/1125193005/diff/60001/src/heap/spaces.h#newcode2439
src/heap/spaces.h:2439: return static_cast<int>(addr - bottom()) /
Page::kPageSize;
On 2015/05/12 17:04:17, Hannes Payer wrote:
cast to intptr_t
Done.
https://codereview.chromium.org/1125193005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
