LGTM if comments are addressed
https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc#newcode532
src/compiler/js-typed-lowering.cc:532: return Changed(replacement);
This should be Replaced(replacement), just be clear.
Changed(replacement) kind of works by accident.
https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc#newcode541
src/compiler/js-typed-lowering.cc:541: return Changed(replacement);
Ditto
https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc#newcode780
src/compiler/js-typed-lowering.cc:780: return Changed(load);
Ditto
https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc#newcode787
src/compiler/js-typed-lowering.cc:787: return Changed(load);
Ditto
https://codereview.chromium.org/1134303003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
