On 2015/05/19 08:24:27, jarin wrote:
On 2015/05/19 08:18:10, Benedikt Meurer wrote:
> Hey Jaro,
>
> This is the change we talked about briefly last week. I know it's not
required
> currently, but I feel better if we make sure that we never mess with
inner
frame
> states during inlining. Please take a look.
>
> Thanks,
> Benedikt
It seems to me that if you just do not connect the outer state if there is
already one it is also wrong. You should really connect the frame state
to the
end of the chain. Since we do not have any test coverage for that I would
prefer
just CHECKing that there is no outer frame state.
As discussed offline, I now see that this patch is in fact connecting the
frame
state to the end of the chain.
lgtm.
https://codereview.chromium.org/1134973006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
