https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js
File test/simdjs/harness-adapt.js (right):
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js#newcode29
test/simdjs/harness-adapt.js:29:
On 2015/05/19 08:36:01, bbudge (OOO week of 5-11) wrote:
"use strict"; ?
Done.
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/harness-adapt.js#newcode47
test/simdjs/harness-adapt.js:47:
_oldLoad('test/simdjs/data/src/benchmarks/' + filename);
On 2015/05/19 07:17:48, Michael Achenbach wrote:
Did you test that? Not sure if it'll work as the working dir for
benchmark
execution is the same as the json file of the benchmark or relatively
deeper (as
specified in the file).
We can also fix that later when landing the benchmark stuff.
So the benchmarks or these tests run ok if you change the cwd to where
the test is.
This also works to run both, though the benchmarks are slow.
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/testcfg.py
File test/simdjs/testcfg.py (right):
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/testcfg.py#newcode1
test/simdjs/testcfg.py:1: # Copyright 2015 the V8 project authors. All
rights reserved.
On 2015/05/19 07:17:48, Michael Achenbach wrote:
Please use shorter licence headers as in
https://code.google.com/p/chromium/codesearch#chromium/src/v8/test/unittests/unittests.status
Also in the other files.
Done.
https://codereview.chromium.org/1147743004/diff/1/test/simdjs/testcfg.py#newcode56
test/simdjs/testcfg.py:56: tests = [
On 2015/05/19 07:17:48, Michael Achenbach wrote:
This wraps another runner? Is there a way to get the list of test
cases and then
make the runner execute separately for each test case (passing in the
test
name)? To wrap a runner has several disadvantages:
1. It doesn't use our runner's multiprocessing
2. Any set of test failures will appear as one failure of that runner.
3. The status file can't be use to manipulate specific test runs.
How many atomic tests are called by the runner and how long does that
take?
Ah, good point.
I've changed it round to expose the individual ones.
https://codereview.chromium.org/1147743004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
