Reviewers: Sven Panne,
Message:
As discussed.
Do you think this needs a regression cctest, or shall we just fix it?
Description:
Fix has_pending_exception logic in API's Array::CloneElementAt
BUG=v8:4103
LOG=y
[email protected]
Please review this at https://codereview.chromium.org/1138723003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3, -2 lines):
M src/api.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
ea29d55709ca96df8c6f1cce99b9ad9bf19846e3..b9790eeb07252acb43488b15793d9efc56a4c68e
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -6072,8 +6072,9 @@ MaybeLocal<Object>
Array::CloneElementAt(Local<Context> context,
if (!paragon->IsJSObject()) return Local<Object>();
i::Handle<i::JSObject> paragon_handle(i::JSObject::cast(paragon));
Local<Object> result;
- has_pending_exception = ToLocal<Object>(
- isolate->factory()->CopyJSObject(paragon_handle), &result);
+ has_pending_exception =
+ !ToLocal<Object>(isolate->factory()->CopyJSObject(paragon_handle),
+ &result);
RETURN_ON_FAILED_EXECUTION(Object);
RETURN_ESCAPED(result);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
