Reviewers: rossberg, Yang,
Message:
Created Revert of Reapply "Resolve references to "this" the same way as
normal
variables""
Description:
Revert of Reapply "Resolve references to "this" the same way as normal
variables"" (patchset #2 id:20001 of
https://codereview.chromium.org/1136883006/)
Reason for revert:
Something is deserializing "this" declarations as Variable::NORMAL and not
Variable::THIS https://codereview.chromium.org/1136123010/
Original issue's description:
Reapply "Resolve references to "this" the same way as normal variables""
This reapplies https://codereview.chromium.org/1136073002, along with
the followups:
Remove Scope::scope_uses_this_ flag
https://codereview.chromium.org/1128963005
and
PPC: Resolve references to "this" the same way as normal variables
https://codereview.chromium.org/1134073003
[email protected], [email protected]
LOG=N
BUG=
Committed: https://crrev.com/1efc1e4f7a3d30d5225e9d5cb2585cad7cb17099
Cr-Commit-Position: refs/heads/master@{#28458}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Please review this at https://codereview.chromium.org/1146733002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (+173, -407 lines):
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm64/full-codegen-arm64.cc
M src/arm64/lithium-codegen-arm64.cc
M src/compiler.cc
M src/compiler/ast-graph-builder.h
M src/compiler/ast-graph-builder.cc
M src/contexts.cc
M src/heap/heap.h
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/mips/full-codegen-mips.cc
M src/mips/lithium-codegen-mips.cc
M src/mips64/full-codegen-mips64.cc
M src/mips64/lithium-codegen-mips64.cc
M src/parser.cc
M src/ppc/full-codegen-ppc.cc
M src/ppc/lithium-codegen-ppc.cc
M src/preparser.h
M src/runtime/runtime-debug.cc
M src/runtime/runtime-scopes.cc
M src/scopeinfo.cc
M src/scopes.h
M src/scopes.cc
M src/variables.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M test/cctest/test-parsing.cc
M test/cctest/test-serialize.cc
M test/mjsunit/debug-scopes.js
D test/mjsunit/harmony/arrow-functions-this.js
M test/mjsunit/testcfg.py
D test/mjsunit/this-dynamic-lookup.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
