Reviewers: rossberg,
Message:
Round and round we go! Patchset 1 is patch as reverted; PS2 adds a slot to
ScopeInfo for scopes with a "this" binding so we can know what
Variable::Kind to
use when deserializing "this" bindings, to fix the bug found in
http://code.google.com/p/chromium/issues/detail?id=487105.
Description:
Reapply "Resolve references to "this" the same way as normal variables""
This reapplies https://codereview.chromium.org/1136073002, along with
the followups:
Remove Scope::scope_uses_this_ flag
https://codereview.chromium.org/1128963005
and
PPC: Resolve references to "this" the same way as normal variables
https://codereview.chromium.org/1134073003
[email protected]
LOG=N
BUG=
Review URL: https://codereview.chromium.org/1136883006
Cr-Commit-Position: refs/heads/master@{#28458}
Please review this at https://codereview.chromium.org/1140633003/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (+503, -196 lines):
M src/arm/full-codegen-arm.cc
M src/arm/lithium-codegen-arm.cc
M src/arm64/full-codegen-arm64.cc
M src/arm64/lithium-codegen-arm64.cc
M src/compiler.cc
M src/compiler/ast-graph-builder.h
M src/compiler/ast-graph-builder.cc
M src/contexts.cc
M src/heap/heap.h
M src/ia32/full-codegen-ia32.cc
M src/ia32/lithium-codegen-ia32.cc
M src/mips/full-codegen-mips.cc
M src/mips/lithium-codegen-mips.cc
M src/mips64/full-codegen-mips64.cc
M src/mips64/lithium-codegen-mips64.cc
M src/objects.h
M src/parser.cc
M src/ppc/full-codegen-ppc.cc
M src/ppc/lithium-codegen-ppc.cc
M src/preparser.h
M src/runtime/runtime-debug.cc
M src/runtime/runtime-scopes.cc
M src/scopeinfo.cc
M src/scopes.h
M src/scopes.cc
M src/variables.cc
M src/x64/full-codegen-x64.cc
M src/x64/lithium-codegen-x64.cc
M test/cctest/test-parsing.cc
M test/cctest/test-serialize.cc
M test/mjsunit/debug-scopes.js
A test/mjsunit/harmony/arrow-functions-this.js
M test/mjsunit/testcfg.py
A + test/mjsunit/this-dynamic-lookup.js
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
