For now I'm leaving the calls to SetSourcePosition as is, but but yes, we should do it in a consistent way in the future. I'll look at this in a separate change.
http://codereview.chromium.org/496009/diff/14001/14008 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/496009/diff/14001/14008#newcode1012 src/arm/fast-codegen-arm.cc:1012: Move(context, r3); On 2010/01/04 12:48:38, Kevin Millikin wrote: > Indentation looks off here. Done. http://codereview.chromium.org/496009/diff/14001/14008#newcode1461 src/arm/fast-codegen-arm.cc:1461: } else { On 2010/01/04 12:48:38, Kevin Millikin wrote: > Too many spaces after else? Done. http://codereview.chromium.org/496009/diff/14001/14008#newcode1517 src/arm/fast-codegen-arm.cc:1517: __ CallRuntime(Runtime::kNumberAdd, 2); On 2010/01/04 12:48:38, Kevin Millikin wrote: > For the INC case, we can use stm to push the two arguments to the runtime call. > Didn't we decide that was better? In this case I didn't use it since the previous call to TO_NUMBER returns the result already in r0. We'd have to move the first argument into a higher-number register to use stm (or change the order of the arguments for the runtime call NumberAdd.) http://codereview.chromium.org/496009/diff/14001/14008#newcode1551 src/arm/fast-codegen-arm.cc:1551: } break; On 2010/01/04 12:48:38, Kevin Millikin wrote: > We usually put break inside the braces. Done. http://codereview.chromium.org/496009/diff/14001/14008#newcode1563 src/arm/fast-codegen-arm.cc:1563: } break; On 2010/01/04 12:48:38, Kevin Millikin wrote: > And here. Done. http://codereview.chromium.org/496009/diff/14001/14005 File src/compiler.cc (right): http://codereview.chromium.org/496009/diff/14001/14005#newcode653 src/compiler.cc:653: // expression context state. On 2010/01/04 12:48:38, Kevin Millikin wrote: > Comment can go away. Done. http://codereview.chromium.org/496009/diff/14001/14004 File src/ia32/fast-codegen-ia32.cc (right): http://codereview.chromium.org/496009/diff/14001/14004#newcode1527 src/ia32/fast-codegen-ia32.cc:1527: } break; On 2010/01/04 12:48:38, Kevin Millikin wrote: > Break inside braces. Done. http://codereview.chromium.org/496009/diff/14001/14004#newcode1542 src/ia32/fast-codegen-ia32.cc:1542: } break; On 2010/01/04 12:48:38, Kevin Millikin wrote: > And here. Done. http://codereview.chromium.org/496009 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
