Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Fixed DCHECK in StoreIC::CompileHandler().
BUG=chromium:489597
LOG=N
Please review this at https://codereview.chromium.org/1123153005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -1 lines):
M src/ic/ic.cc
Index: src/ic/ic.cc
diff --git a/src/ic/ic.cc b/src/ic/ic.cc
index
c73398f5a5716a92fcc52658253941e758a3b5bc..ea5c57270f6c4cd0669ddba81b8144cc33b3cbe7
100644
--- a/src/ic/ic.cc
+++ b/src/ic/ic.cc
@@ -1625,7 +1625,8 @@ Handle<Code> StoreIC::CompileHandler(LookupIterator*
lookup,
// This is currently guaranteed by checks in StoreIC::Store.
Handle<JSObject> receiver =
Handle<JSObject>::cast(lookup->GetReceiver());
Handle<JSObject> holder = lookup->GetHolder<JSObject>();
- DCHECK(!receiver->IsAccessCheckNeeded());
+ DCHECK(!receiver->IsAccessCheckNeeded() ||
+ isolate()->IsInternallyUsedPropertyName(lookup->name()));
switch (lookup->state()) {
case LookupIterator::TRANSITION: {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
