LGTM
https://codereview.chromium.org/1139603005/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/1139603005/diff/1/src/parser.cc#newcode3095
src/parser.cc:3095:
Runtime::FunctionForId(Runtime::kThrowIteratorResultNotAnObject),
Can you use a NewTypeError Expression instead of adding this runtime
function?
Since we already have it I think it is OK but we should probably remove
some of these later...
https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destructuring.js
File test/mjsunit/harmony/destructuring.js (right):
https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destructuring.js#newcode394
test/mjsunit/harmony/destructuring.js:394: var [a,b,c] = [1,2,3];
ws
https://codereview.chromium.org/1139603005/diff/1/test/mjsunit/harmony/destructuring.js#newcode535
test/mjsunit/harmony/destructuring.js:535:
Can you add some recursive tests too?
https://codereview.chromium.org/1139603005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
