Reviewers: arv, dstence, michael_dawson,
Description:
Fix 'PPC: [strong] Function arity check should be based on required
parameters'
lwa cannot encode unaligned displacements. lwz is acceptable here
since the shift right will perform the sign-extension on PPC64 for us.
[email protected], [email protected], [email protected]
BUG=
Please review this at https://codereview.chromium.org/1134913004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/ppc/builtins-ppc.cc
Index: src/ppc/builtins-ppc.cc
diff --git a/src/ppc/builtins-ppc.cc b/src/ppc/builtins-ppc.cc
index
ee89116313a7f9707b8b66436561e6a27d888f41..48e45db98165189c50bb754fdebbc12fe9a6f89d
100644
--- a/src/ppc/builtins-ppc.cc
+++ b/src/ppc/builtins-ppc.cc
@@ -1778,7 +1778,7 @@ void
Builtins::Generate_ArgumentsAdaptorTrampoline(MacroAssembler* masm) {
__ beq(&no_strong_error, cr0);
// What we really care about is the required number of arguments.
- __ lwa(r7, FieldMemOperand(r7, SharedFunctionInfo::kLengthOffset));
+ __ lwz(r7, FieldMemOperand(r7, SharedFunctionInfo::kLengthOffset));
#if V8_TARGET_ARCH_PPC64
// See commment near kLenghtOffset in src/objects.h
__ srawi(r7, r7, kSmiTagSize);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
