LGTM with nits.
https://codereview.chromium.org/1148583002/diff/1/src/lookup.cc
File src/lookup.cc (right):
https://codereview.chromium.org/1148583002/diff/1/src/lookup.cc#newcode358
src/lookup.cc:358: DCHECK(ExoticIndexState::kNotExotic !=
exotic_index_state_);
nit: the condition reads more naturally if you swap it (variable !=
kConstant).
https://codereview.chromium.org/1148583002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1148583002/diff/1/src/objects.cc#newcode315
src/objects.cc:315: THROW_NEW_ERROR(it->isolate(),
nit: consider "Isolate* isolate = it->isolate();" at the top of the
function to avoid a bunch of useless noise here and below.
https://codereview.chromium.org/1148583002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
