LGTM with comments.
https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc#newcode4362
src/objects.cc:4362: AssertNoContextChange ncc(it->isolate());
nit: it->isolate() is used often enough that I'd pull it out to
"Isolate* isolate = it->isolate();" to make all the places using it look
a bit cleaner. Up to you though.
https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc#newcode4396
src/objects.cc:4396: // TODO(verwaest): Use GetPropertyWithInterceptor?
Sounds good. Or pull out the common core into a standalone helper. Can
be a follow-up CL though.
https://codereview.chromium.org/1147863002/diff/20001/src/objects.cc#newcode4408
src/objects.cc:4408: if (name->IsSymbol() &&
!interceptor->can_intercept_symbols()) {
I don't think this can happen; you've ruled this out above in line
4367/4368.
https://codereview.chromium.org/1147863002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
