Reviewers: dcarney, ulan, Benedikt Meurer,
Description:
[ARM64] [turbofan] Use 'mvn' rather than an equivalent 'orn'.
`mvn xd, xn` is an architectural alias for `orn xd, xzr, xm`, so this
doesn't change code generation at all, but it's tidier and it addresses
a TODO.
BUG=
Please review this at https://codereview.chromium.org/1151483002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -3 lines):
M src/compiler/arm64/code-generator-arm64.cc
Index: src/compiler/arm64/code-generator-arm64.cc
diff --git a/src/compiler/arm64/code-generator-arm64.cc
b/src/compiler/arm64/code-generator-arm64.cc
index
b32a53b9cb09931405d5e7e0fa5008da8170ca38..775f519519a0df93089cc1da5c17f7dbcf14e8ae
100644
--- a/src/compiler/arm64/code-generator-arm64.cc
+++ b/src/compiler/arm64/code-generator-arm64.cc
@@ -558,12 +558,11 @@ void
CodeGenerator::AssembleArchInstruction(Instruction* instr) {
i.InputRegister32(0));
break;
}
- // TODO(dcarney): use mvn instr??
case kArm64Not:
- __ Orn(i.OutputRegister(), xzr, i.InputOperand(0));
+ __ Mvn(i.OutputRegister(), i.InputOperand(0));
break;
case kArm64Not32:
- __ Orn(i.OutputRegister32(), wzr, i.InputOperand32(0));
+ __ Mvn(i.OutputRegister32(), i.InputOperand32(0));
break;
case kArm64Neg:
__ Neg(i.OutputRegister(), i.InputOperand(0));
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
