One real issue about arguments adaptor and construct frames. Otherwise just
nits.
https://codereview.chromium.org/1146963002/diff/20001/src/compiler/js-intrinsic-lowering.cc
File src/compiler/js-intrinsic-lowering.cc (right):
https://codereview.chromium.org/1146963002/diff/20001/src/compiler/js-intrinsic-lowering.cc#newcode470
src/compiler/js-intrinsic-lowering.cc:470:
NodeProperties::ReplaceWithValue(node, outer_frame, effect, control);
nit: Please use AdvancedReducer::ReplaceWithValue here, I am currently
switching the reducers over to this method, the old
NodeProperties::ReplaceWithValue is deprecated.
https://codereview.chromium.org/1146963002/diff/20001/src/compiler/js-intrinsic-lowering.cc#newcode486
src/compiler/js-intrinsic-lowering.cc:486: access =
AccessBuilder::ForFrameMarker();
Does this work with arguments adapter frames and construct frames? Can
we have tests for those?
https://codereview.chromium.org/1146963002/diff/20001/src/compiler/simplified-lowering.cc
File src/compiler/simplified-lowering.cc (right):
https://codereview.chromium.org/1146963002/diff/20001/src/compiler/simplified-lowering.cc#newcode1045
src/compiler/simplified-lowering.cc:1045: case
IrOpcode::kLoadFramePointer:
nit: Lets just have both labels (i.e. kLoadStackPointer and
kLoadFramePointer) point to one single return statement.
https://codereview.chromium.org/1146963002/diff/20001/test/mjsunit/get-caller-js-function.js
File test/mjsunit/get-caller-js-function.js (right):
https://codereview.chromium.org/1146963002/diff/20001/test/mjsunit/get-caller-js-function.js#newcode18
test/mjsunit/get-caller-js-function.js:18: c();
nit: Can we wrap all three calls to "c" into an assertEquals checking
the return value?
https://codereview.chromium.org/1146963002/diff/20001/test/mjsunit/get-caller-js-function.js#newcode28
test/mjsunit/get-caller-js-function.js:28: d();
nit: Likewise.
https://codereview.chromium.org/1146963002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
