Reviewers: bradnelson, bbudge,
Message:
PTAL. Feel free to hit the CQ if this looks alright.
Description:
[test] Fix simdjs perf tests.
- Missing resource on android
- Higher timeout on arm
- Fewer runs on arm
- Drop total
- Rename suite so that it fits to the naming scheme (this
means that the few data points we have under the old name
will hang around for a while)
BUG=v8:4124
LOG=N
NOTRY=true
Please review this at https://codereview.chromium.org/1149723002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+20, -6 lines):
M test/simdjs/SimdJs.json
M test/simdjs/generate.py
Index: test/simdjs/SimdJs.json
diff --git a/test/simdjs/SimdJs.json b/test/simdjs/SimdJs.json
index
e6686b90a0f241a839628c79c2bed0b02700b15e..1df0e2ed1b308ca75fde37b86b9f5bc26f1fdfbb
100644
--- a/test/simdjs/SimdJs.json
+++ b/test/simdjs/SimdJs.json
@@ -3,13 +3,15 @@
"--harmony-object",
"test/simdjs/harness-adapt.js"
],
- "name": "SIMDJS",
+ "name": "SimdJs",
"path": [
"../../"
],
"resources": [
"test/simdjs/data/src/benchmarks/base.js",
"test/simdjs/data/src/ecmascript_simd.js",
+ "test/simdjs/harness-adapt.js",
+ "test/simdjs/harness-finish.js",
"test/simdjs/data/src/benchmarks/kernel-template.js",
"test/simdjs/data/src/benchmarks/averageFloat32x4.js",
"test/simdjs/data/src/benchmarks/averageFloat32x4LoadFromInt8Array.js",
@@ -29,6 +31,9 @@
"test/simdjs/data/src/benchmarks/memcpy.js"
],
"run_count": 5,
+ "run_count_android_arm": 3,
+ "run_count_android_arm64": 3,
+ "run_count_arm": 3,
"tests": [
{
"flags": [
@@ -439,6 +444,8 @@
]
}
],
- "total": true,
+ "timeout_android_arm": 120,
+ "timeout_android_arm64": 120,
+ "timeout_arm": 120,
"units": "ms"
}
\ No newline at end of file
Index: test/simdjs/generate.py
diff --git a/test/simdjs/generate.py b/test/simdjs/generate.py
index
9dc41cff57016e3b8182dd63828c1c606129c9e0..4fe00ba2be7fa3c4d7274730eb9a582c0475e60b
100755
--- a/test/simdjs/generate.py
+++ b/test/simdjs/generate.py
@@ -26,13 +26,20 @@ tests = re.findall("load \\(\\'([^']+)[.]js\\'\\)",
run_js)
tests = [t for t in tests if t not in SKIP_FILES]
output = {
- 'name': 'SIMDJS',
+ 'name': 'SimdJs',
'run_count': 5,
+ 'run_count_arm': 3,
+ 'run_count_android_arm': 3,
+ 'run_count_android_arm64': 3,
+ 'timeout_arm': 120,
+ 'timeout_android_arm': 120,
+ 'timeout_android_arm64': 120,
'units': 'ms',
- 'total': True,
'resources': [
'test/simdjs/data/src/benchmarks/base.js',
- 'test/simdjs/data/src/ecmascript_simd.js'
+ 'test/simdjs/data/src/ecmascript_simd.js',
+ 'test/simdjs/harness-adapt.js',
+ 'test/simdjs/harness-finish.js'
] + ['test/simdjs/data/src/benchmarks/%s.js' % t for t in tests],
'flags': ['--harmony-object', 'test/simdjs/harness-adapt.js'],
'path': ['../../'],
@@ -52,5 +59,5 @@ output = {
for test in tests],
}
-with open(os.path.join(SCRIPT_DIR, 'SimdJS.json'), 'w') as fh:
+with open(os.path.join(SCRIPT_DIR, 'SimdJs.json'), 'w') as fh:
fh.write(json.dumps(output, separators=(',',': '), indent=2,
sort_keys=True))
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
