checked myself now that i'm on a laptop – I didn't change this as much as I
wanted.
In general, I think __clang__ checks should be kept to a minimum and the
gcc and
msvc macro checks should instead mostly do the right thing in clang mode
too. In
this case:
https://codereview.chromium.org/1145213004/diff/1/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/1145213004/diff/1/include/v8config.h#newcode273
include/v8config.h:273: #elif defined(_MSC_VER)
don't we support all the stuff in here too? Should this be an #if
instead of an #elif?
https://codereview.chromium.org/1145213004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
