Yes, if this pattern occurs more often, I think that this definitely a good idea!
--Florian On Tue, Jan 5, 2010 at 12:57 PM, Anton Muhin <[email protected]> wrote: > As a minor question: could it be added to macro-assembler or it won't worth > it? > > yours, > anton. > > On Tue, Jan 5, 2010 at 2:48 PM, <[email protected]> wrote: > > LGTM. > > > > > > http://codereview.chromium.org/519035/diff/3001/10 > > File src/ia32/codegen-ia32.cc (right): > > > > http://codereview.chromium.org/519035/diff/3001/10#newcode7753 > > src/ia32/codegen-ia32.cc:7753: __ j(equal, &adaptor); > > Couldn't you simplify this code to be > > > > Label exit; > > __ j(not_equal, &exit); > > __ mov(eax, Operand(...)); > > __ bind(exit); > > > > and reuse the ret instruction? > > > > http://codereview.chromium.org/519035 > > > > -- > > v8-dev mailing list > > [email protected] > > http://groups.google.com/group/v8-dev > > > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
