https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode33
src/harmony-typedarray.js:33: function ConstructTypedArray(constructor,
array) {
On 2015/05/20 19:22:31, arv wrote:
Also, this function is defined twice... was there a merge?
Yes. OK, I learned my lesson, not to do git conflict resolution late at
night. It was intended to be called in ConstructTypedArrayLike, but
apparently I forgot to call it there (a bug that goes back to the first
time I tried to land this code). Before you ask: it'd be hard to test
this code directly until @@species goes in; I have a test in
TypedArray.from, but no test that TypedArray.map reaches this code.
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode36
src/harmony-typedarray.js:36: if (!IS_SPEC_OBJECT(constructor) ||
IS_UNDEFINED(constructor.prototype) ||
On 2015/05/20 18:50:07, adamk wrote:
Can you use %IsConstructor here? These checks look quite odd. (if this
function
is unused, you can of course ignore this comment)
The check is supposed to be an approximation of checking that this is a
TypedArray class. I replaced IS_SPEC_OBJECT with %IsConstructor, but I
still need the next couple checks.
https://codereview.chromium.org/1145013002/diff/1/src/harmony-typedarray.js#newcode265
src/harmony-typedarray.js:265: "fill", TypedArrayFill,
On 2015/05/20 18:50:07, adamk wrote:
This is a dup of the sorted line above.
Done.
https://codereview.chromium.org/1145013002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
