LGTM all
http://codereview.chromium.org/521028/diff/1/3 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/521028/diff/1/3#newcode8004 src/ia32/codegen-ia32.cc:8004: __ j(greater, &runtime); Nevermind, I see that this just implements an assert. The conversion to zero should have happened before we call the regexp. http://codereview.chromium.org/521028/diff/1/3#newcode8146 src/ia32/codegen-ia32.cc:8146: __ shr(edx, 1); // Number of capture registers back from smi. Add a comment that the value is always non-negative (to explain why it's safe to use shr isntead of sar). http://codereview.chromium.org/521028/diff/1/3#newcode8175 src/ia32/codegen-ia32.cc:8175: __ test(edi, Immediate(0x80000000)); Yes, and even if it didn't, test(edi,edi) would be shorter. http://codereview.chromium.org/521028/diff/1/20 File src/x64/regexp-macro-assembler-x64.cc (right): http://codereview.chromium.org/521028/diff/1/20#newcode79 src/x64/regexp-macro-assembler-x64.cc:79: * - String* input_string (input string) Good catch. We no longer pass the string as a location. http://codereview.chromium.org/521028
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
