LGTM, two nits
https://codereview.chromium.org/1150953002/diff/40001/src/objects-debug.cc
File src/objects-debug.cc (right):
https://codereview.chromium.org/1150953002/diff/40001/src/objects-debug.cc#newcode50
src/objects-debug.cc:50: // TODO(yangguo): Use this check once
crbug/436911 has been fixed.
That should be fixed now, we can remove the uncommented code.
https://codereview.chromium.org/1150953002/diff/40001/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):
https://codereview.chromium.org/1150953002/diff/40001/src/snapshot/serialize.cc#newcode1732
src/snapshot/serialize.cc:1732: // TODO(bbudge) Generalize to other
alignment constraints.
TODO(bbudge): ...
https://codereview.chromium.org/1150953002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
