LGTM with nits.
https://codereview.chromium.org/1154483002/diff/1/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/1154483002/diff/1/src/harmony-array.js#newcode269
src/harmony-array.js:269:
nit: surrounding code seems to be happy with just one empty line.
https://codereview.chromium.org/1154483002/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/1154483002/diff/1/src/harmony-typedarray.js#newcode48
src/harmony-typedarray.js:48: var IsNaN
nit: trailing ';' for consistency
https://codereview.chromium.org/1154483002/diff/1/src/harmony-typedarray.js#newcode65
src/harmony-typedarray.js:65: IsNaN = from.IsNaN
nit: trailing ';' for consistency
https://codereview.chromium.org/1154483002/diff/1/src/i18n.js
File src/i18n.js (right):
https://codereview.chromium.org/1154483002/diff/1/src/i18n.js#newcode957
src/i18n.js:957:
SetFunctionName(Intl.Collator.prototype.resolvedOptions,
nit: should still fit on one line
https://codereview.chromium.org/1154483002/diff/1/src/i18n.js#newcode1232
src/i18n.js:1232: SetFunctionName(Intl.NumberFormat.supportedLocalesOf,
nit: should still fit on one line
https://codereview.chromium.org/1154483002/diff/1/src/i18n.js#newcode1654
src/i18n.js:1654:
SetFunctionName(Intl.DateTimeFormat.supportedLocalesOf,
nit: should still fit on one line
https://codereview.chromium.org/1154483002/diff/1/src/i18n.js#newcode1835
src/i18n.js:1835:
SetFunctionName(Intl.v8BreakIterator.supportedLocalesOf,
nit: should still fit on one line
https://codereview.chromium.org/1154483002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
