https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h
File src/compiler/node.h (right):
https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#newcode95
src/compiler/node.h:95:
On 2015/05/21 14:14:02, Michael Starzinger wrote:
nit: Maybe #undef BOUNDS_CHECK here again.
Done.
https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#newcode297
src/compiler/node.h:297: typedef BitField<unsigned, 29, 4>
InlineCapacityField;
On 2015/05/21 14:14:02, Michael Starzinger wrote:
Looks like this is exceeding 32-bit here?
Finger math is best math!
https://codereview.chromium.org/1150923003/diff/60001/src/compiler/node.h#newcode319
src/compiler/node.h:319: #define VERIFY(node) Verify(node)
On 2015/05/21 14:14:02, Michael Starzinger wrote:
This macro probably cannot be undef'ed, because it's used in the
.cc-file. So
can we move it into the .cc-file (or at least choose a slightly less
ambiguous
name like VERIFY_NODE for it), because it would "leak" into many
compilation
units.
Fixed this to be a regular function in debug mode, inline empty function
in release mode.
https://codereview.chromium.org/1150923003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
