lgtm
We could also move this code into the GC epilogue to also uncommit when
there
is
no idle time (e.g. on mobile). WDYT?
Yes and the same for scaling allocation factor based on throughput.
https://codereview.chromium.org/1148633005/diff/1/src/heap/gc-tracer.cc
File src/heap/gc-tracer.cc (right):
https://codereview.chromium.org/1148633005/diff/1/src/heap/gc-tracer.cc#newcode626
src/heap/gc-tracer.cc:626: return static_cast<size_t>(allocated_bytes /
kThroughputTimeFrame);
(+ 1) to avoid returning 0 if allocated_bytes < kThroughputTimeFrame?
https://codereview.chromium.org/1148633005/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/1148633005/diff/1/src/heap/heap.cc#newcode4570
src/heap/heap.cc:4570: return
heap_state.current_new_space_allocation_throughput_in_bytes_per_ms <
check for
heap_state.current_new_space_allocation_throughput_in_bytes_per_ms == 0
and be conservative in that case?
https://codereview.chromium.org/1148633005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
