On 2015/05/22 at 09:37:35, jarin wrote:
https://codereview.chromium.org/1136553006/diff/80001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1136553006/diff/80001/src/objects.h#newcode177
src/objects.h:177: enum SharedFlag { NOT_SHARED, SHARED };
On 2015/05/22 09:27:34, binji wrote:
> On 2015/05/22 at 08:37:47, jochen wrote:
> > not needed?
>
> It was suggested in the other CL that this would make some of the
callsites
> clearer. But no, not strictly needed. Wdyt?
Indeed, I suggested that for making it clear at call sites what the
argument
does. We do this in other parts of v8 and I like that. (And it was
suggested to
me to use enum for function arguments when I joined v8).
Some related reading material:
https://existentialtype.wordpress.com/2011/03/15/boolean-blindness/
ok
can we make it an enum class then? with that this looks good
https://codereview.chromium.org/1136553006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
