Reviewers: paul.l..., dusmil.imgtec, akos.palfi.imgtec, balazs.kilvady,
https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc
File test/cctest/test-disasm-mips.cc (right):
https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc#newcode635
test/cctest/test-disasm-mips.cc:635: if (kArchVariant == kMips32r6) {
On 2015/05/22 11:03:37, dusmil.imgtec wrote:
It should be IsMipsArchVariant() as above.
Done.
https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc#newcode680
test/cctest/test-disasm-mips.cc:680: if (kArchVariant == kMips32r6) {
On 2015/05/22 11:03:37, dusmil.imgtec wrote:
ditto.
Done.
https://codereview.chromium.org/1145223002/diff/1/test/cctest/test-disasm-mips.cc#newcode725
test/cctest/test-disasm-mips.cc:725: if (kArchVariant == kMips32r6 ||
kArchVariant == kMips32r2) {
On 2015/05/22 11:03:37, dusmil.imgtec wrote:
ditto.
Done.
Description:
MIPS: Add float instructions and test coverage, part two
Implement assembler, disassembler tests for all instructions for mips32 and
mips64. Additionally, add missing single precision float instructions for
r2 and
r6 architecture variants in assembler, simulator and disassembler with
corresponding tests.
Please review this at https://codereview.chromium.org/1145223002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+3661, -77 lines):
M src/mips/assembler-mips.h
M src/mips/assembler-mips.cc
M src/mips/constants-mips.h
M src/mips/constants-mips.cc
M src/mips/disasm-mips.cc
M src/mips/simulator-mips.h
M src/mips/simulator-mips.cc
M src/mips64/assembler-mips64.h
M src/mips64/assembler-mips64.cc
M src/mips64/constants-mips64.h
M src/mips64/constants-mips64.cc
M src/mips64/disasm-mips64.cc
M src/mips64/simulator-mips64.h
M src/mips64/simulator-mips64.cc
M test/cctest/test-assembler-mips.cc
M test/cctest/test-assembler-mips64.cc
M test/cctest/test-disasm-mips.cc
M test/cctest/test-disasm-mips64.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
