LGTM. I am fine with addressing the comment in a follow-up CL.
https://codereview.chromium.org/1150293002/diff/20001/src/full-codegen.h
File src/full-codegen.h (right):
https://codereview.chromium.org/1150293002/diff/20001/src/full-codegen.h#newcode712
src/full-codegen.h:712: void EnterCatchBlock();
nit: If we extend this to the "try-finally" statement as well, then it
might make sense to rename the function to ClearMessageObject() or
similar instead.
https://codereview.chromium.org/1150293002/diff/20001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/1150293002/diff/20001/test/cctest/test-heap.cc#newcode5583
test/cctest/test-heap.cc:5583: " throw 'message';"
As discussed offline: We should have the same problem with a finally
block. Correct? Consider the following example:
try {
throw 'message';
} finally {
break;
}
https://codereview.chromium.org/1150293002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
