Reviewers: jochen,

Message:
PTAL

Description:
[test] Fix no-exceptions cc flag.

BUG=chromium:425187
LOG=n

Please review this at https://codereview.chromium.org/1154833002/

Base URL: https://chromium.googlesource.com/v8/v8.git@master

Affected files (+12, -5 lines):
  M build/standalone.gypi


Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index cf89f74d3c429913080bf2f1681268c4b93fd4e4..8bafda91d13e1c0be964602ac7e480b3ce051e7e 100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -338,7 +338,6 @@
           '-fPIC',
         ],
         'cflags!': [
-          '-fno-exceptions',
           '-fomit-frame-pointer',
         ],
         'ldflags': [
@@ -387,12 +386,16 @@
           '-Wno-unused-parameter',
           '-Wno-long-long',
           '-pthread',
-          '-fno-exceptions',
           '-pedantic',
# Don't warn about the "struct foo f = {0};" initialization pattern.
           '-Wno-missing-field-initializers',
         ],
-        'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
+        'cflags_cc': [
+          '-Wnon-virtual-dtor',
+          '-fno-exceptions',
+          '-fno-rtti',
+          '-std=gnu++0x',
+        ],
         'ldflags': [ '-pthread', ],
         'conditions': [
[ 'clang==1 and (v8_target_arch=="x64" or v8_target_arch=="arm64")', {
@@ -418,11 +421,15 @@
           '-Wall',
           '<(werror)',
           '-Wno-unused-parameter',
-          '-fno-exceptions',
# Don't warn about the "struct foo f = {0};" initialization pattern.
           '-Wno-missing-field-initializers',
         ],
-        'cflags_cc': [ '-Wnon-virtual-dtor', '-fno-rtti', '-std=gnu++0x' ],
+        'cflags_cc': [
+          '-Wnon-virtual-dtor',
+          '-fno-exceptions',
+          '-fno-rtti',
+          '-std=gnu++0x',
+        ],
         'conditions': [
           [ 'visibility=="hidden"', {
             'cflags': [ '-fvisibility=hidden' ],


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to