Reviewers: arv,
Description:
[turbofan] Simplify handing of spreads in array literals.
[email protected]
TEST=mjsunit/harmony/spread-array
Please review this at https://codereview.chromium.org/1154873002/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_graph-builder-computed-property-names-deopt
Affected files (+2, -9 lines):
M src/compiler/ast-graph-builder.cc
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc
b/src/compiler/ast-graph-builder.cc
index
561cd50395740d974d5e19b1af69c1847ecd0dd6..20c9577f080f3173a5995d56ca5dc88f85f630ab
100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -1996,15 +1996,11 @@ void
AstGraphBuilder::VisitArrayLiteral(ArrayLiteral* expr) {
}
// In case the array literal contains spread expressions it has two
parts. The
- // first part is the "static" array which has a literal index is
handled
+ // first part is the "static" array which has a literal index is handled
// above. The second part is the part after the first spread expression
// (inclusive) and these elements gets appended to the array. Note that
the
// number elements an iterable produces is unknown ahead of time.
- bool has_spread = array_index < expr->values()->length();
- if (has_spread) {
- environment()->Pop(); // Array literal index.
- }
-
+ environment()->Pop(); // Array literal index.
for (; array_index < expr->values()->length(); array_index++) {
Expression* subexpr = expr->values()->at(array_index);
Node* array = environment()->Pop();
@@ -2032,9 +2028,6 @@ void AstGraphBuilder::VisitArrayLiteral(ArrayLiteral*
expr) {
environment()->Push(result);
}
- if (!has_spread) {
- environment()->Pop(); // Array literal index.
- }
ast_context()->ProduceValue(environment()->Pop());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
