LGTM

http://codereview.chromium.org/518056/diff/1/3
File src/v8natives.js (right):

http://codereview.chromium.org/518056/diff/1/3#newcode453
src/v8natives.js:453: if (!IS_OBJECT(obj) && !IS_FUNCTION(obj)) {
How about !(IS_OBJECT(obj) || IS_FUNCTION(obj))?

http://codereview.chromium.org/518056/diff/1/5
File test/mjsunit/get-prototype-of.js (right):

http://codereview.chromium.org/518056/diff/1/5#newcode65
test/mjsunit/get-prototype-of.js:65: GetPrototypeOfObject({x:5});
I see no tests for functions here.  Consider adding some.

http://codereview.chromium.org/518056
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to