Reviewers: jochen,
Message:
Closing. Obsoleted by crrev.com/1156733002.
Description:
Add TODO to implement 'bookmarking' for the streaming stream.
(This implementation is used in streaming parsing. Fixing this will
probably require changing the V8/embedder interface and will take some
more time. The TODO was requested in the crrev.com/1102523003 review,
but I somehow dropped this.)
BUG=chromium:470930
LOG=N
[email protected]
Please review this at https://codereview.chromium.org/1131543002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -0 lines):
M src/scanner-character-streams.h
Index: src/scanner-character-streams.h
diff --git a/src/scanner-character-streams.h
b/src/scanner-character-streams.h
index
36d84bc0f6b5d82a16b005bef0ea737138642a1f..369cb28e7ba9b7ab29558e77195622a248da8abe
100644
--- a/src/scanner-character-streams.h
+++ b/src/scanner-character-streams.h
@@ -83,6 +83,8 @@ class Utf8ToUtf16CharacterStream: public
BufferedUtf16CharacterStream {
// ExternalStreamingStream is a wrapper around an ExternalSourceStream (see
// include/v8.h) subclass implemented by the embedder.
+//
+// TODO(vogelheim): Implement (Set|ResetTo)Bookmark methods for this
stream.
class ExternalStreamingStream : public BufferedUtf16CharacterStream {
public:
ExternalStreamingStream(ScriptCompiler::ExternalSourceStream*
source_stream,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
