lgtm
https://codereview.chromium.org/1148653007/diff/40001/src/unicode.cc
File src/unicode.cc (right):
https://codereview.chromium.org/1148653007/diff/40001/src/unicode.cc#newcode229
src/unicode.cc:229: uchar Utf8::CalculateValue(const byte* str, size_t
max_length, size_t* cursor) {
Not sure if worth the effort, but this might be more compact if written
like this:
uchar c = kBadChar;
size_t length = NonASCIISequenceLength(str[0]);
the if/switch-es would then only handle the success cases and update
c;
*cursor += (c == kBadChar) ? 1 : length;
return c;
I guess it's a matter of taste. You pick.
https://codereview.chromium.org/1148653007/diff/40001/src/unicode.cc#newcode282
src/unicode.cc:282: // Code poits outside of the unicode range.
poits -> points
https://codereview.chromium.org/1148653007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
