Remove the jump to runtime for two-byte strings and retest?
Remember to file a bug report for the missing x64 and ARM version of this optimization. http://codereview.chromium.org/525085/diff/1/4 File src/ia32/assembler-ia32.cc (right): http://codereview.chromium.org/525085/diff/1/4#newcode756 src/ia32/assembler-ia32.cc:756: EMIT(0xF3); EnsureSpace ensure_space(this); last_pc_ = pc_; ? http://codereview.chromium.org/525085/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/525085/diff/1/2#newcode9337 src/ia32/codegen-ia32.cc:9337: __ jmp(&runtime); Hmm, remove and make sure to test again? http://codereview.chromium.org/525085/diff/1/2#newcode9358 src/ia32/codegen-ia32.cc:9358: // As from is a smi it is 2 * the value which matches the size of a two byte 2 * -> two times http://codereview.chromium.org/525085/diff/1/3 File src/ia32/codegen-ia32.h (right): http://codereview.chromium.org/525085/diff/1/3#newcode757 src/ia32/codegen-ia32.h:757: // additional setup and checking in GenerateCopyCharactersREP adds to much to -> too http://codereview.chromium.org/525085
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
