All done. PTAL at patch 6.
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi#newcode291
build/standalone.gypi:291: ['OS!="mac"', {
On 2015/05/22 19:57:25, earthdok wrote:
Following common.gypi, you should probably change this to "posix and
not mac".
As it is now, it's not obvious why Mac is special.
Done. But I'm not convinced that our posix variable is meaningful. Our
gyp is a bit of a mess and the posix variable seems not to be set in a
nested scope and then copied out.
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi#newcode310
build/standalone.gypi:310: '-Wl,--as-needed',
On 2015/05/22 19:57:25, earthdok wrote:
Do not add this unless the problem manifests in standalone v8. Looking
at the
referenced issue, it looks like we don't even need this in Chromium
any longer.
Done.
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi#newcode312
build/standalone.gypi:312: }],
On 2015/05/22 19:57:25, earthdok wrote:
Need to define the ADDRESS_SANITIZER symbol here, as well as in the
Mac config:
https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=2806
(This is not done uniformly with other tools because the ASan symbol
is defined
across multiple platforms, whereas the other tools are Linux-only.)
(Please ignore the "MEMORY_SANITIZER_INITIAL_SIZE" symbol in line 2808
- this is
not relevant to V8.)
Done. See above. Btw: codesearch links get outdated quite quickly in
common.gypi. I try to use fixed git hashes:
https://chromium.googlesource.com/chromium/src/+/11784f3a12/build/common.gypi#2836
I assume MEMORY_TOOL_REPLACES_ALLOCATOR is also not important?
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi#newcode320
build/standalone.gypi:320: # TODO(earthdok): Re-enable.
http://crbug.com/427202
On 2015/05/22 19:57:25, earthdok wrote:
The referenced issue does not affect standalone V8, so this TODO
should look the
same as the TODOs for TSan, MSan blacklists.
Generally speaking, I don't think you want to have blacklists. If you
do, you
would have to either pull them from Chromium, or keep them in sync
with the
blacklists in Chromium.
Removing these TODOs for now.
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi#newcode339
build/standalone.gypi:339: }],
On 2015/05/22 19:57:25, earthdok wrote:
define LEAK_SANITIZER?
Done.
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi#newcode378
build/standalone.gypi:378: # Use libc++ (third_party/libc++ and
third_party/libc++abi) instead of
On 2015/05/22 19:57:25, earthdok wrote:
Those pathnames are no longer correct after the move to buildtools,
please fix.
Done.
https://codereview.chromium.org/1146863006/diff/80001/build/standalone.gypi#newcode379
build/standalone.gypi:379: # stdlibc++ as standard library. This is
intended to use for instrumented
On 2015/05/22 19:57:25, earthdok wrote:
Please fix: "intended to be used for".
Done.
https://codereview.chromium.org/1146863006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
