LGTM once comment is addressed. Thanks for doing this.


https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):

https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc#newcode275
src/compiler/verifier.cc:275: CHECK(use->opcode() == IrOpcode::kEnd);
Please use CHECK_EQ(IrOpcode::kEnd, use->opcode()) here and below. Makes
debugging easier, since the output will tell you directly what's wrong.

https://codereview.chromium.org/1153963006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.
  • [v8-dev] Re: [t... bmeurer

Reply via email to