Reviewers: Alexander Potapenko, earthdok,
Message:
PTAL. After incorporating the take-aways from
https://codereview.chromium.org/1146863006/, there still remain problems for
using libcxx with v8 snapshot builds (here asan and tsan). The msan bot
works
because it's nosnap.
Will I need a host/target toolset separation in libcxx?
Description:
[test] Use instrumented libc++ for asan and tsan builds.
BUG=
Please review this at https://codereview.chromium.org/1143173005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+19, -6 lines):
M build/standalone.gypi
Index: build/standalone.gypi
diff --git a/build/standalone.gypi b/build/standalone.gypi
index
c01c802386fab220ae95ba66f80d41d66de2ef28..10f1a4c93817ac679d74bebe20134993314be8d9
100644
--- a/build/standalone.gypi
+++ b/build/standalone.gypi
@@ -76,6 +76,10 @@
'lsan%': 0,
'msan%': 0,
'tsan%': 0,
+ # Use libc++ (buildtools/third_party/libc++ and
+ # buildtools/third_party/libc++abi) instead of stdlibc++ as standard
+ # library. This is intended to be used for instrumented builds.
+ 'use_custom_libcxx%': 0,
# goma settings.
# 1 to use goma.
@@ -101,6 +105,7 @@
'lsan%': '<(lsan)',
'msan%': '<(msan)',
'tsan%': '<(tsan)',
+ 'use_custom_libcxx%': '<(use_custom_libcxx)',
# Add a simple extra solely for the purpose of the cctests
'v8_extra_library_files': ['../test/cctest/test-extra.js'],
@@ -179,6 +184,18 @@
'clang%': 1,
'use_allocator%': 'none',
}],
+ ['asan==1 and OS=="linux"', {
+ 'use_custom_libcxx%': 1,
+ }],
+ ['tsan==1', {
+ 'use_custom_libcxx%': 1,
+ }],
+ ['msan==1', {
+ # Use a just-built, MSan-instrumented libc++ instead of the
system-wide
+ # libstdc++. This is required to avoid false positive reports
whenever
+ # the C++ standard library is used.
+ 'use_custom_libcxx%': 1,
+ }],
],
# Default ARM variable settings.
'arm_version%': 'default',
@@ -367,13 +384,9 @@
],
}],
],
- # TODO(machenbach): Share this between all *san configs like in
- # common.gypi.
+ }],
+ ['use_custom_libcxx==1', {
'dependencies': [
- # Use libc++ (buildtools/third_party/libc++ and
- # buildtools/third_party/libc++abi) instead of stdlibc++ as
- # standard library. This is intended to be used for for
- # instrumented builds.
'<(DEPTH)/buildtools/third_party/libc++/libc++.gyp:libcxx_proxy',
],
}],
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
