On 2015/05/26 15:21:55, Michael Achenbach wrote:
PTAL. After incorporating the take-aways from
https://codereview.chromium.org/1146863006/, there still remain problems
for
using libcxx with v8 snapshot builds (here asan and tsan). The msan bot
works
because it's nosnap.
Will I need a host/target toolset separation in libcxx?
No no, this has nothing to do with snapshots. The problem is that we're not
passing -fPIC when compiling libc++.
* -fPIC is requred for any shared library build on x86_64 Linux
* Chromium supplies it everywhere:
https://chromium.googlesource.com/chromium/src/+/6138f464f771b325fb839940113342361a443c65/build/common.gypi#500
* v8 standalone doesn't do that, so libc++ will not compile unless PIC is
enabled implicitly by either of -fsanitize=...
* Only -fsanitize=memory actually implies PIC, -fsanitize={address,thread}
don't
(I was wrong previously if I said they did - sorry).
I'm submitting a CL to buildtools/ to fix some libc++ build flags, so I'll
just
add this flag to the list.
On an unrelated note, something that caught my eye in the logs:
GYP_DEFINES': 'asan=1 clang=1 dcheck_always_on=0 fastbuild=1
Note that Chromium sets fastbuild=0 for non-Linux ASan bots:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/chromium/config.py&l=407
glider@ should be able to explain the significance of that.
https://codereview.chromium.org/1143173005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
