Reviewers: tandrii(chromium), Jakob,
Message:
PTAL. This hopefully gives more clues about the occasionally hanging test
runner
on XP.
Description:
[test] Verbose test runner output on windows.
[email protected]
Please review this at https://codereview.chromium.org/1156133006/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+15, -1 lines):
M tools/run-tests.py
M tools/testrunner/local/execution.py
M tools/testrunner/local/progress.py
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
274bb18ac62227573d98ab705eaacb805705cd36..cfbca3aa9d6b003430b28337da58a14688d5cd88
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -540,8 +540,14 @@ def Execute(arch, mode, args, options, suites,
workspace):
# Predictable mode is slower.
timeout *= 2
+ # TODO(machenbach): Remove temporary verbose output on windows after
+ # debugging driver-hung-up on XP.
+ verbose_output = (
+ options.verbose or
+ utils.IsWindows() and options.progress == "verbose"
+ )
ctx = context.Context(arch, MODES[mode]["execution_mode"], shell_dir,
- mode_flags, options.verbose,
+ mode_flags, verbose_output,
timeout, options.isolates,
options.command_prefix,
options.extra_flags,
Index: tools/testrunner/local/execution.py
diff --git a/tools/testrunner/local/execution.py
b/tools/testrunner/local/execution.py
index
35e0efe7cfed032be4601bae3f9efcdf2b5d8755..49efa6bd891f2b5d41904ea470375c50d243cf80
100644
--- a/tools/testrunner/local/execution.py
+++ b/tools/testrunner/local/execution.py
@@ -150,6 +150,7 @@ class Runner(object):
self.indicator.HasRun(test, has_unexpected_output or test.run > 1)
if has_unexpected_output:
# Rerun test failures after the indicator has processed the results.
+ self._VerbosePrint("Attempting to rerun test after failure.")
self._MaybeRerun(pool, test)
# Update the perf database if the test succeeded.
return not has_unexpected_output
@@ -241,7 +242,9 @@ class Runner(object):
if update_perf:
self._RunPerfSafe(lambda: self.perfdata.UpdatePerfData(test))
finally:
+ self._VerbosePrint("Closing process pool.")
pool.terminate()
+ self._VerbosePrint("Closing database connection.")
self._RunPerfSafe(lambda: self.perf_data_manager.close())
if self.perf_failures:
# Nuke perf data in case of failures. This might not work on
windows as
@@ -254,6 +257,10 @@ class Runner(object):
# Make sure that any allocations were printed in predictable mode.
assert not self.context.predictable or self.printed_allocations
+ def _VerbosePrint(self, text):
+ if self.context.verbose:
+ print(text, flush=True)
+
def GetCommand(self, test):
d8testflag = []
shell = test.suite.shell()
Index: tools/testrunner/local/progress.py
diff --git a/tools/testrunner/local/progress.py
b/tools/testrunner/local/progress.py
index
421f9417a5646a803c2e4ce5593c4150398351d5..e40872f1824848294d98efb7f309908b9808d8c4
100644
--- a/tools/testrunner/local/progress.py
+++ b/tools/testrunner/local/progress.py
@@ -130,6 +130,7 @@ class VerboseProgressIndicator(SimpleProgressIndicator):
else:
outcome = 'pass'
print 'Done running %s: %s' % (test.GetLabel(), outcome)
+ sys.stdout.flush()
def Heartbeat(self):
print 'Still working...'
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
