Reviewers: adamk, Michael Starzinger,
Message:
PTAL
I accidentally left some incorrect code in there.
Description:
Cleanup ast numbering for super.prop in arrows
Follow up to https://codereview.chromium.org/1135243004
For now we need to call set_base_id in AstNumberingVisitor because
TurboFan needs a bailout id for super.prop in a lot of cases.
BUG=None
LOG=N
[email protected], [email protected]
Please review this at https://codereview.chromium.org/1153053005/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -8 lines):
M src/ast-numbering.cc
M src/compiler/ast-graph-builder.cc
Index: src/ast-numbering.cc
diff --git a/src/ast-numbering.cc b/src/ast-numbering.cc
index
6f5701309cf0310edb5e628b27ecaab03afce923..83c37550ea170caec155f816b974613644592430
100644
--- a/src/ast-numbering.cc
+++ b/src/ast-numbering.cc
@@ -171,7 +171,6 @@ void
AstNumberingVisitor::VisitThisFunction(ThisFunction* node) {
void AstNumberingVisitor::VisitSuperReference(SuperReference* node) {
IncrementNodeCount();
DisableOptimization(kSuperReference);
- ReserveFeedbackSlots(node);
node->set_base_id(ReserveIdRange(SuperReference::num_ids()));
Visit(node->this_var());
Visit(node->home_object_var());
Index: src/compiler/ast-graph-builder.cc
diff --git a/src/compiler/ast-graph-builder.cc
b/src/compiler/ast-graph-builder.cc
index
194e068ce1a08455ee5862bf35f9737a0c964a34..0b60bd03ffdc937f08d51ee5036da77b62c4e049
100644
--- a/src/compiler/ast-graph-builder.cc
+++ b/src/compiler/ast-graph-builder.cc
@@ -2225,13 +2225,6 @@ void AstGraphBuilder::VisitThrow(Throw* expr) {
void AstGraphBuilder::VisitProperty(Property* expr) {
- if (expr->obj()->IsSuperReference()) {
- // TODO(turbofan): Implement super here.
- SetStackOverflow();
- ast_context()->ProduceValue(jsgraph()->UndefinedConstant());
- return;
- }
-
Node* value;
VectorSlotPair pair = CreateVectorSlotPair(expr->PropertyFeedbackSlot());
if (expr->key()->IsPropertyName()) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
