https://codereview.chromium.org/1127063003/diff/360001/src/scopes.h
File src/scopes.h (right):
https://codereview.chromium.org/1127063003/diff/360001/src/scopes.h#newcode375
src/scopes.h:375: Variable* parameter(int index) const {
On 2015/05/26 20:59:11, caitp wrote:
On 2015/05/26 20:34:02, adamk wrote:
> Is this called anywhere (besides your new caller in scopes.cc)? It
scares me a
> bit that callers might pull a Variable out of this now that these
are bogus.
Yes, it's called in function prologues to move parameters pushed on
the stack
into context. It should never actually have to "do" that since the
"original"
param variables are never allocated right now, so I think it's
safe-ish.
Thanks for the pointer, I see how my git grep missed that now.
I agree that it's "safe-ish" :)
https://codereview.chromium.org/1127063003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
