Here's a reason; this happens when I apply this patch:
$ tools/run-tests.py --arch x64 --mode release nonexistent
[...snip...]
Running tests for x64.release
No connection to distribution server; running tests locally.
Traceback (most recent call last):
File "tools/run-tests.py", line 655, in <module>
sys.exit(Main())
File "tools/run-tests.py", line 502, in Main
code = Execute(arch, mode, args, options, suites, workspace)
File "tools/run-tests.py", line 646, in Execute
exit_code = runner.Run(options.j)
File "...v8/tools/testrunner/local/execution.py", line 207, in Run
self.indicator.Done()
File "...v8/tools/testrunner/local/progress.py", line 170, in Done
self.PrintProgress('Done')
File "...v8/tools/testrunner/local/progress.py", line 205, in
PrintProgress
self.runner.total),
ZeroDivisionError: integer division or modulo by zero
Clearly, printing "No tests to run" looks much cleaner than a random
exception,
and is much easier to get right than hardening all the other code to handle
the
zero corner case correctly.
https://codereview.chromium.org/1153103003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
