Reviewers: Jakob,
Message:
PTAL. Need to merge back for the infrastructure to work on all branches.
Description:
[test] Remove default for zero test cases.
BUG=
Please review this at https://codereview.chromium.org/1152303003/
Base URL: https://chromium.googlesource.com/v8/[email protected]
Affected files (+6, -8 lines):
M tools/run-tests.py
M tools/testrunner/local/progress.py
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index
9288bbf14ef88a95812b7aaecb794ba2b3f643b1..e61986a3f253738131791faaff88d3b5fd5f66b4
100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -598,10 +598,6 @@ def Execute(arch, mode, args, options, suites,
workspace):
if options.report:
verbose.PrintReport(all_tests)
- if num_tests == 0:
- print "No tests to run."
- return 0
-
# Run the tests, either locally or distributed on the network.
start_time = time.time()
progress_indicator = progress.PROGRESS_INDICATORS[options.progress]()
Index: tools/testrunner/local/progress.py
diff --git a/tools/testrunner/local/progress.py
b/tools/testrunner/local/progress.py
index
421f9417a5646a803c2e4ce5593c4150398351d5..a02e9842b1ea3181851dc98cc59791905a58cc2d
100644
--- a/tools/testrunner/local/progress.py
+++ b/tools/testrunner/local/progress.py
@@ -199,10 +199,12 @@ class CompactProgressIndicator(ProgressIndicator):
def PrintProgress(self, name):
self.ClearLine(self.last_status_length)
elapsed = time.time() - self.start_time
+ progress = 0 if not self.runner.total else (
+ ((self.runner.total - self.runner.remaining) * 100) //
+ self.runner.total)
status = self.templates['status_line'] % {
'passed': self.runner.succeeded,
- 'remaining': (((self.runner.total - self.runner.remaining) * 100) //
- self.runner.total),
+ 'progress': progress,
'failed': len(self.runner.failed),
'test': name,
'mins': int(elapsed) / 60,
@@ -219,7 +221,7 @@ class ColorProgressIndicator(CompactProgressIndicator):
def __init__(self):
templates = {
'status_line': ("[%(mins)02i:%(secs)02i|"
- "\033[34m%%%(remaining) 4d\033[0m|"
+ "\033[34m%%%(progress) 4d\033[0m|"
"\033[32m+%(passed) 4d\033[0m|"
"\033[31m-%(failed) 4d\033[0m]: %(test)s"),
'stdout': "\033[1m%s\033[0m",
@@ -235,7 +237,7 @@ class
MonochromeProgressIndicator(CompactProgressIndicator):
def __init__(self):
templates = {
- 'status_line': ("[%(mins)02i:%(secs)02i|%%%(remaining) 4d|"
+ 'status_line': ("[%(mins)02i:%(secs)02i|%%%(progress) 4d|"
"+%(passed) 4d|-%(failed) 4d]: %(test)s"),
'stdout': '%s',
'stderr': '%s',
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
